mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39531: [WIP] Clarify NetworkInfo semantics for IP addresses and group policies.
Date Thu, 22 Oct 2015 01:30:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103506
-----------------------------------------------------------


Bad patch!

Reviews applied: [39531]

Failed command: ./support/apply-review.sh -n -r 39531

Error:
 2015-10-22 01:30:35 URL:https://reviews.apache.org/r/39531/diff/raw/ [4873/4873] -> "39531.patch"
[1]
error: patch failed: include/mesos/mesos.proto:1351
error: include/mesos/mesos.proto: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 22, 2015, 12:35 a.m., Connor Doyle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 12:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
>     https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message allows
framework authors to communicate with network isolation modules via a first-class message
type to request IP addresses and network group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors and module
implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the container.
> 2) It's difficult for application developers to understand the final policy when multiple
IP addresses can be assigned with differing isolation policies.
> 
> NOTE: the slave should also be updated in order to set the new IpAddress message in ContainerStatus
in case network isolation modules are not installed.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 4a16be1 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message