mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty
Date Wed, 21 Oct 2015 18:07:25 GMT


> On Oct. 21, 2015, 6:05 p.m., Marco Massenzio wrote:
> > include/mesos/v1/mesos.proto, lines 211-213
> > <https://reviews.apache.org/r/39514/diff/1/?file=1102339#file1102339line211>
> >
> >     I know it's not your code, but could you please remove `automagically` (there's
nothing magic in a string assignment :)
> >     
> >     Please use: `SchedulerDriver`
> >     
> >     The comment could read more easily if you changed it to:
> >     ```
> >     // When the Scheduler HTTP API is used for registering the framework,
> >     // the `user` field should be explicitly set, unless the 
> >     // `--switch_user` flag is explicitly set to `false` on
> >     // the agent nodes (otherwise, the tasks will fail).
> >     // For the same reason, if the user is set, it should be an
> >     // existing user on the agent nodes, with the necessary permissions.

bad formatting, apologies:
```
// When the Scheduler HTTP API is used for registering the framework, 
// the `user` field should be explicitly set, unless the 
// `--switch_user` flag is explicitly set to `false` on
// the agent nodes (otherwise, the tasks will fail).
// For the same reason, if the user is set, it should be an
// existing user on the agent nodes, with the necessary permissions.
```


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39514/#review103440
-----------------------------------------------------------


On Oct. 21, 2015, 8:48 a.m., Liqiang Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39514/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 8:48 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3747
>     https://issues.apache.org/jira/browse/MESOS-3747
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add validation to check whether FrameworkInfo.user be empty. Fail
> framework action if framework user is empty.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
>   src/master/validation.cpp 9c7c8c123c5bd13b99a2c1c7318515d687b4bc34 
> 
> Diff: https://reviews.apache.org/r/39514/diff/
> 
> 
> Testing
> -------
> 
> make check done.
> 
> 
> Thanks,
> 
> Liqiang Lin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message