mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 39453: Added HTTP docs to libprocess README.md.
Date Wed, 21 Oct 2015 17:54:19 GMT


> On Oct. 21, 2015, 1:51 a.m., Guangya Liu wrote:
> > 3rdparty/libprocess/README.md, line 452
> > <https://reviews.apache.org/r/39453/diff/8/?file=1101276#file1101276line452>
> >
> >     s/noting/nothing

Here, I'm saying something to the effect of "It's also worthy of note that if multiple requests...",
so the word "noting" is appropriate.


> On Oct. 21, 2015, 1:51 a.m., Guangya Liu wrote:
> > 3rdparty/libprocess/README.md, line 403
> > <https://reviews.apache.org/r/39453/diff/8/?file=1101276#file1101276line403>
> >
> >     Can you please add sth for how to get the listening port?

Good call, thanks Guangya :-)


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/#review103337
-----------------------------------------------------------


On Oct. 21, 2015, 5:53 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39453/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 5:53 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HTTP docs to libprocess README.md.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39453/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/greggomann/b5b35a164a006bec9357
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message