> On Oct. 20, 2015, 10:03 p.m., Ben Whitehead wrote:
> > docs/scheduler-http-api.md, lines 36-48
> > <https://reviews.apache.org/r/39452/diff/4/?file=1102104#file1102104line36>
> >
> > The proposed grammar I made was based of the ABNF of the HTTP 1.1 spec here:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html#sec2.1 This spec should probably be
linked to so the user can follow it.
> >
> > `LF` is the method used to refer to `\n` character and I think we should be
consistent with that.
> >
> > `1*(DIGIT)` was there to denote the repetition of digit. Meaning at least 1
digit.
> >
> > `DIGIT` is already defined in the rfc I linked to.
> >
> > `NL` is non-standard and should be removed in favor of `LF`
Hey Ben - this is great information, it would have been great to have all this in the first
iteration, would have saved a great deal of time.
> On Oct. 20, 2015, 10:03 p.m., Ben Whitehead wrote:
> > docs/scheduler-http-api.md, line 51
> > <https://reviews.apache.org/r/39452/diff/4/?file=1102104#file1102104line51>
> >
> > This section of the document is expalaining RecordIO not http clients. Please
remove this sentence.
same comment here - this has not changed since the first iteration.
> On Oct. 20, 2015, 10:03 p.m., Ben Whitehead wrote:
> > docs/scheduler-http-api.md, lines 66-68
> > <https://reviews.apache.org/r/39452/diff/4/?file=1102104#file1102104line66>
> >
> > These two lines don't flow together very well, a single paragraph should contain
the motivation and justification.
This was updated - you are probably commenting on a stale version of the patch.
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103314
-----------------------------------------------------------
On Oct. 20, 2015, 9:58 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2015, 9:58 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
>
>
> Diffs
> -----
>
> docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787
>
> Diff: https://reviews.apache.org/r/39452/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Massenzio
>
>
|