mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 38978: Add post-rewrite hook.
Date Tue, 20 Oct 2015 20:05:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38978/#review103299
-----------------------------------------------------------

Ship it!


Thanks so much haosdent!
This will save many people hours of trouble :-)
I'm going to add in the exit behavior similar to the pre-commit hook that vinod updated.


support/hooks/post-rewrite (lines 21 - 29)
<https://reviews.apache.org/r/38978/#comment161283>

    I just touched up these comments.


- Joris Van Remoortere


On Oct. 14, 2015, 5:10 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38978/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2953
>     https://issues.apache.org/jira/browse/MESOS-2953
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add post-rewrite hook.
> 
> 
> Diffs
> -----
> 
>   bootstrap 779b33cdcb88b2417769bb046a17b47cd6042f2d 
>   support/hooks/post-rewrite PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38978/diff/
> 
> 
> Testing
> -------
> 
> test manually
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message