mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
Date Tue, 20 Oct 2015 19:20:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
-----------------------------------------------------------

(Updated Oct. 20, 2015, 7:20 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am e64aa6baeab9d816bb42242e3c9234d4da80f401

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 1c776cd2facfb86854c7b2a8fe6be7949b566587

  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp f16ef1998c9b271b35063a2f07cf1c15d6b8bea0

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp eaeed7393b1c44f04737e18cd90a6fc292aa061d


Diff: https://reviews.apache.org/r/39382/diff/


Testing
-------

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message