mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 39452: MESOS-3566 Description of RecordIO format
Date Tue, 20 Oct 2015 16:24:56 GMT


> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 44
> > <https://reviews.apache.org/r/39452/diff/2/?file=1101221#file1101221line44>
> >
> >     Nit: Can we just check for `200` here (since the response from `Subscribe` should
be `200` for a good response ?

we removed this code


> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 51
> > <https://reviews.apache.org/r/39452/diff/2/?file=1101221#file1101221line51>
> >
> >     Is `int(...)` in python unsigned and 64 bytes ? That is the requirements we
mention in our docs.

no (signed) and yes (64 bits - not bytes :) - but that's now largely irrelevant, as we removed
the code.


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103172
-----------------------------------------------------------


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
>     https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message