mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 39194: Added documentation and scripts for building mesos.apache.org website locally in a Docker container.
Date Tue, 20 Oct 2015 07:49:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39194/#review103227
-----------------------------------------------------------

Ship it!


Worked flawlessly for me the first time! So much simpler now that it's all in one repo too.
Great work!


support/site-docker/README.md (line 7)
<https://reviews.apache.org/r/39194/#comment161215>

    Since you specify `.`, shouldn't you `cd support/site-docker` first?
    Otherwise, you could suggest `docker build -t mesos/website support/site-docker`
    I don't like assuming that they're already in `support/site` just because they're reading
the README


- Adam B


On Oct. 19, 2015, 5:42 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39194/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos, Adam B and Dave Lester.
> 
> 
> Bugs: MESOS-3694
>     https://issues.apache.org/jira/browse/MESOS-3694
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/site-docker/Dockerfile PRE-CREATION 
>   support/site-docker/README.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39194/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message