mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39457: Document messages in messages.proto.
Date Tue, 20 Oct 2015 00:42:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39457/
-----------------------------------------------------------

(Updated Oct. 19, 2015, 5:42 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
-------

Finish first pass.


Summary (updated)
-----------------

Document messages in messages.proto.


Bugs: MESOS-3759
    https://issues.apache.org/jira/browse/MESOS-3759


Repository: mesos


Description (updated)
-------

A brief summary of each message was added.  

For messages with an associated Event/Call API object, a reference to the object was added.
Additionally, there is a great deal of documentation overlap between these messages and the
comments in mesos/scheduler.hpp and v1/scheduler/scheduler.proto.  Where necessary, some notes
were added about the backwards compatibility of messages which are not instantiated in the
code base.


Diffs (updated)
-----

  src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 

Diff: https://reviews.apache.org/r/39457/diff/


Testing
-------

None.  (Comment change only)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message