mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <>
Subject Re: Review Request 39429: Replaced volatile, GCC intrinsics with std::atomic.
Date Mon, 19 Oct 2015 04:48:59 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 19, 2015, 4:48 a.m.)

Review request for mesos and Joris Van Remoortere.

Bugs: MESOS-3326

Repository: mesos


See MESOS-3326. We adopted std::atomic in most of the code base earlier (commits
87de003c6e8a, 4b938052b6af, and 4a01850c5540), but a few places were omitted;
those locations are fixed by this commit.

There's one last place to fix: we use the GCC intrinsic __sync_synchronize() in
3rdparty/libprocess/include/process/logging.h. Because that is used to protect
modifications to the FLAGS_v variable defined by glog, we can't easily adapt it
to use std::atomic.

Diffs (updated)

  3rdparty/libprocess/include/process/owned.hpp 17c42614155fed8fec185f29f9a9babb71ff5f85 
  3rdparty/libprocess/include/process/shared.hpp 021807b961bb55f11c9e04327135bd83f4d86c21

  3rdparty/libprocess/src/tests/process_tests.cpp a3c57a261c09f7b76b78225719e64a26f2d66cd3




Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message