mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39219: Windows: Added support for `slave/state.cpp`.
Date Sun, 18 Oct 2015 17:13:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39219/#review103062
-----------------------------------------------------------



src/slave/state.hpp (line 131)
<https://reviews.apache.org/r/39219/#comment160923>

    How is this compiling for you?



src/slave/state.cpp (line 650)
<https://reviews.apache.org/r/39219/#comment160920>

    `isError()` reads better.



src/slave/state.cpp (lines 652 - 653)
<https://reviews.apache.org/r/39219/#comment160921>

    We now have an error to return from the `Try`



src/slave/state.cpp (lines 730 - 733)
<https://reviews.apache.org/r/39219/#comment160922>

    Same as above.


- Joris Van Remoortere


On Oct. 15, 2015, 8:31 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39219/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2015, 8:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633,
MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
>     https://issues.apache.org/jira/browse/MESOS-3615
>     https://issues.apache.org/jira/browse/MESOS-3627
>     https://issues.apache.org/jira/browse/MESOS-3628
>     https://issues.apache.org/jira/browse/MESOS-3629
>     https://issues.apache.org/jira/browse/MESOS-3630
>     https://issues.apache.org/jira/browse/MESOS-3631
>     https://issues.apache.org/jira/browse/MESOS-3633
>     https://issues.apache.org/jira/browse/MESOS-3658
>     https://issues.apache.org/jira/browse/MESOS-3659
>     https://issues.apache.org/jira/browse/MESOS-3660
>     https://issues.apache.org/jira/browse/MESOS-3693
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added support for `slave/state.cpp`.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a 
>   src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab 
> 
> Diff: https://reviews.apache.org/r/39219/diff/
> 
> 
> Testing
> -------
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS
X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message