mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39217: Windows: Added `stout/os/ftruncate.hpp`.
Date Sun, 18 Oct 2015 17:13:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39217/#review103059
-----------------------------------------------------------

Ship it!


I think there are places like `os/posix/fork.hpp` that we need to adjust to use this ftruncate.


3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ftruncate.hpp (line 16)
<https://reviews.apache.org/r/39217/#comment160915>

    `sys/types.h`
    `stout/error.hpp`
    `stout/stringify.hpp`



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ftruncate.hpp (lines 27 - 28)
<https://reviews.apache.org/r/39217/#comment160917>

    `stringify()`?



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ftruncate.hpp (lines 19 - 20)
<https://reviews.apache.org/r/39217/#comment160916>

    order
    `stout/error.hpp`
    `stout/stringify.hpp`



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ftruncate.hpp (lines 30 - 31)
<https://reviews.apache.org/r/39217/#comment160918>

    `stringify()`?


- Joris Van Remoortere


On Oct. 16, 2015, 8 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39217/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 8 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added `stout/os/ftruncate.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/ftruncate.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/ftruncate.hpp PRE-CREATION

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/ftruncate.hpp PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/39217/diff/
> 
> 
> Testing
> -------
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS
X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message