mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <>
Subject Re: Review Request 37336: Simplified the caller interface to process::Subprocess
Date Sun, 18 Oct 2015 15:22:17 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 18, 2015, 3:22 p.m.)

Review request for mesos, Joris Van Remoortere and Michael Park.


Fixed compile error which was not caught by local `make && make check`

Bugs: MESOS-3035

Repository: mesos


Jira: MESOS-3035

    The original API for `process::Subprocess` still left a lot of legwork
    to do for the caller; we have now added an `execute()` method
    that returns a `Future<CommandResult>` (also introduced with this patch) which
    contains useful information about the command invocation; the exit code;
    stdout and, optionally, stderr too.
    Once the Future completes, if successful, the caller will be able to retrieve
    stdout/stderr; whether the command was successful; and whether it received a signal

Diffs (updated)

  3rdparty/libprocess/include/process/subprocess.hpp d2341a53aac7c779668ee80983f73158fd44bff5

  3rdparty/libprocess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a



make check


Marco Massenzio

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message