mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39182: Windows: Enable ip_tests.
Date Sun, 18 Oct 2015 00:13:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39182/#review102170
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 18)
<https://reviews.apache.org/r/39182/#comment159726>

    Comments end with periods.
    e.g. `// For `_mkdir`.`
    Same below.



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 22 - 23)
<https://reviews.apache.org/r/39182/#comment160874>

    I remember from a long time ago that we include in this order to avoid symbol re-definitions.
    We can't expect everyone to know this, let's add a comment here.


- Joris Van Remoortere


On Oct. 13, 2015, 6:27 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39182/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 6:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3439 and MESOS-3629
>     https://issues.apache.org/jira/browse/MESOS-3439
>     https://issues.apache.org/jira/browse/MESOS-3629
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Enable ip_tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 90551541f59889e96b21dbe1b65d3904850464c2

>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp d1e2df6151149e03ffb4a76e2c24ff78b891e016

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 50e35f43d87c69a83a9e7d039d1881404ea8be38

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 94292f8a46ec31bbaf6e52f48109322bbe123f70

> 
> Diff: https://reviews.apache.org/r/39182/diff/
> 
> 
> Testing
> -------
> 
> Ran stout_tests from VS.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message