mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.
Date Sun, 18 Oct 2015 00:13:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review103033
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines 78 - 82)
<https://reviews.apache.org/r/39202/#comment160875>

    Any reason not to keep these alphabetized?


- Joris Van Remoortere


On Oct. 15, 2015, 8:31 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2015, 8:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt f0de224b0d7924344fb1945b387b728a7241df87

>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 577aac82f527f3cce9f5b0cd24cc51091c311789

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 60108ff598fb075584196aa3d8e8e66e726c9f2a

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake d60bce237ec73f462fd373590a3589d554e76fc3

> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message