mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39208: Windows: Add windows support to `stout/protobuf.hpp`.
Date Sun, 18 Oct 2015 00:12:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39208/#review103037
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp (lines 42 - 44)
<https://reviews.apache.org/r/39208/#comment160878>

    let's pull the subdir out.
    let's include close as per Joseph's comment.


- Joris Van Remoortere


On Oct. 13, 2015, 6:31 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39208/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3634
>     https://issues.apache.org/jira/browse/MESOS-3634
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Add windows support to `stout/protobuf.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 2285ce9eaba668d5215c108849055fe92163da4d

> 
> Diff: https://reviews.apache.org/r/39208/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message