mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
Date Fri, 16 Oct 2015 21:19:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review102993
-----------------------------------------------------------


Bad patch!

Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180]

Failed command: ./support/apply-review.sh -n -r 39180

Error:
 2015-10-16 21:19:05 URL:https://reviews.apache.org/r/39180/diff/raw/ [16738/16738] ->
"39180.patch" [1]
error: patch failed: src/tests/scheduler_http_api_tests.cpp:295
error: src/tests/scheduler_http_api_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 16, 2015, 7:50 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 7:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp a042d061159c83e1652e7288b90809981d2818c9

>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda

> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> -------
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows
10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message