mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 39385: Fixed link conversion regexp in website.
Date Fri, 16 Oct 2015 04:42:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39385/
-----------------------------------------------------------

(Updated Oct. 16, 2015, 4:42 a.m.)


Review request for mesos and Dave Lester.


Repository: mesos


Description
-------

The previous regexp was:

    /\((.*)(\.md)\)/

Given text like:

    Text (comment): [link](foo.md)

This will greedily match ".*", so \1 is bound to "comment): [link](foo", which
seems unlikely to be the desired result.


Diffs
-----

  site/Rakefile 9fe4730579ee0e802880e6e3547b4e550be41c8c 

Diff: https://reviews.apache.org/r/39385/diff/


Testing (updated)
-------

Tested using "http://rubular.com/" -- didn't actually test on mesos-website-container, since
it doesn't use the site code from Git just yet.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message