mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Review Request 39379: Windows: Prepared agent for Windows changes to `stout/flags/flags.hpp`.
Date Fri, 16 Oct 2015 04:34:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39379/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

When we remove the line that includes `stout/os.hpp` from
`stout/flags/flags.hpp`, it will break `slave/launcher.cpp`. Our
solution is to directly include the parts of `os.hpp` that are relevant
to the launcher.


Diffs
-----

  src/slave/containerizer/isolators/posix.hpp ee9d275e7fe5fc22c1bab86dd0a558cc8ab9044e 
  src/slave/containerizer/launcher.cpp 6649d35ec593d264e8508a8195f2470f05888c0a 

Diff: https://reviews.apache.org/r/39379/diff/


Testing
-------

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message