mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.
Date Fri, 16 Oct 2015 03:55:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39365/#review102860
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39365]

All tests passed.

- Mesos ReviewBot


On Oct. 16, 2015, 12:30 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39365/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 12:30 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Artem Harutyunyan, and Vinod Kone.
> 
> 
> Bugs: MESOS-3748
>     https://issues.apache.org/jira/browse/MESOS-3748
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master detector is created during construction of the `MesosProcess`.  If the flags
cannot be loaded or if the `MasterDetector::create` fails, the master detector will be null
and will result in a segfault if it is used during initialization.
> 
> 
> Diffs
> -----
> 
>   src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712 
> 
> Diff: https://reviews.apache.org/r/39365/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> ```
> export DEFAULT_PRINCIPAL=root
> build/src/event-call-framework --master="asdf://127.0.0.1:5050"
> ```
> Check that it does not segfault.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message