-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39353/#review102839
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 15, 2015, 12:17 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39353/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 12:17 p.m.)
>
>
> Review request for mesos, Jojy Varghese and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The existing docker image parsing did not work in many cases: if a digest is present,
a registry port is included. And it could not resolve the ambiguity that exists between the
registry and the repository.
>
> This follows docker's approach to parsing, which is a bit hacky due to the way the registry
and repository are disambiguated, see the comments.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto f2ea4fc62507ce30b7a7981fd6a8c4749eb97190
> src/slave/containerizer/provisioner/docker/message.hpp 6368bf4caec6f8c3ac97282f41c55381f920bce9
> src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
> src/slave/containerizer/provisioner/docker/store.cpp 637c97c0973bda492826803a962c99635647692d
> src/tests/containerizer/provisioner_docker_tests.cpp 9c3c45a81be6398722a37911788e347a4e91cce8
>
> Diff: https://reviews.apache.org/r/39353/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>
|