mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39365: HTTP Scheduler should abort when MasterDetector create fails.
Date Fri, 16 Oct 2015 00:03:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39365/
-----------------------------------------------------------

(Updated Oct. 15, 2015, 5:03 p.m.)


Review request for mesos, Anand Mazumdar and Artem Harutyunyan.


Changes
-------

Change ABORT to EXIT.


Bugs: MESOS-3748
    https://issues.apache.org/jira/browse/MESOS-3748


Repository: mesos


Description
-------

If not, the process will segfault during initialization.


Diffs (updated)
-----

  src/scheduler/scheduler.cpp 56801ca6ffc9f9f0e4bd12dbf535e9c5251c2712 

Diff: https://reviews.apache.org/r/39365/diff/


Testing (updated)
-------

`make check`

```
export DEFAULT_PRINCIPAL=root
build/src/event-call-framework --master="asdf://127.0.0.1:5050"
```
Check that it does not segfault.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message