-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39351/#review102810
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39347, 39348, 39349, 39350, 39351]
All tests passed.
- Mesos ReviewBot
On Oct. 15, 2015, 6:05 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39351/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 6:05 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adopt os::pipe in Mesos.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
> src/slave/containerizer/linux_launcher.cpp c03b89eb0678825b03a052874d6262f377a39e13
> src/slave/containerizer/mesos/containerizer.cpp d1fc5a460e7313828014eea999cf4e63dde01921
> src/tests/containerizer/cgroups_tests.cpp 75a3bc0009c037dc18ce319db2eb44630f083e8c
> src/tests/containerizer/isolator_tests.cpp 237f3f27722b01ff92d0dcbaba7910613542a1a7
> src/tests/containerizer/port_mapping_tests.cpp feca2043503436ac9abac6017ae9059b3fcbed21
>
> Diff: https://reviews.apache.org/r/39351/diff/
>
>
> Testing
> -------
>
> OS X and CentOS 6
> make && make check
>
>
> Thanks,
>
> James Peach
>
>
|