-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39345/#review102795
-----------------------------------------------------------
Bad patch!
Reviews applied: [39345]
Failed command: ./support/apply-review.sh -n -r 39345
Error:
2015-10-15 17:21:02 URL:https://reviews.apache.org/r/39345/diff/raw/ [22252/22252] ->
"39345.patch" [1]
Successfully applied: Enable build on FreeBSD, start porting components.
Enable build on FreeBSD, start porting components.
My build steps are:
- Install dependencies from http://mesos.apache.org/gettingstarted/
- Install libexecinfo
- Install clang36 (system clang is 3.4)
- boostrap
- ../configure --with-curl=/usr/local --with-apr=/usr/local --with-svn=/usr/local CC=clang36
CXX=clang++36
- gmake CC=clang36 CXX=clang++36
- gmake CC=clang36 CXX=clang++36 check
I disabled one test because I haven't had a chance to debug it and I wanted to get a bit further
in the test suite. A check run is attached.
Review: https://reviews.apache.org/r/39345
Checking 14 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
configure.ac
src/Makefile.am
stout:
3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp
3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
libprocess:
3rdparty/libprocess/3rdparty/Makefile.am
3rdparty/libprocess/configure.ac
3rdparty/libprocess/src/poll_socket.cpp
3rdparty/libprocess/src/tests/http_tests.cpp
Failed to commit patch
- Mesos ReviewBot
On Oct. 15, 2015, 5:16 p.m., David Forsythe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39345/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 5:16 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: https://issues.apache.org/jira/browse/MESOS-1563
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-1563
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enable build on FreeBSD, start porting components.
>
> My build steps are:
>
> - Install dependencies from http://mesos.apache.org/gettingstarted/
> - Install libexecinfo
> - Install clang36 (system clang is 3.4)
> - boostrap
> - ../configure --with-curl=/usr/local --with-apr=/usr/local --with-svn=/usr/local CC=clang36
CXX=clang++36
> - gmake CC=clang36 CXX=clang++36
> - gmake CC=clang36 CXX=clang++36 check
>
> I disabled one test because I haven't had a chance to debug it and I wanted to get a
bit further in the test suite. A check run is attached.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500
> 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp d1e2df6151149e03ffb4a76e2c24ff78b891e016
> 3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3f829bafe96526bc2263c9f228f85de38c435f60
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 7eb51e8771e95f57548fc35753e75c6d56cd97cd
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp a042d061159c83e1652e7288b90809981d2818c9
> 3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293
> 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp ee2a7a79617612ed448e650cc77608c4962fe5a5
> 3rdparty/libprocess/configure.ac 7c2bcffe5c7be1f7d90e6df470d20a00245bfbff
> 3rdparty/libprocess/src/poll_socket.cpp 28ed102972a9d8f88048aea4046ed837b6a25b35
> 3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9
> configure.ac 66f9b32773861d2921d99189e0fbcaea48c456a9
> src/Makefile.am ba9feb10057a863a41a85ab3612f3a841de01df4
>
> Diff: https://reviews.apache.org/r/39345/diff/
>
>
> Testing
> -------
>
> make check on coreos (I'll get a ubuntu instance for future testing)
>
> gmake check on freebsd 10.2 (failing) (log attached)
>
>
> File Attachments
> ----------------
>
> gmake check
> https://reviews.apache.org/media/uploaded/files/2015/10/15/6661fae4-32bf-409a-b975-05514aae3174__freebsd_check.log
>
>
> Thanks,
>
> David Forsythe
>
>
|