mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <>
Subject Review Request 39330: libprocess: Replaced usage of "volatile" with std::atomic.
Date Wed, 14 Oct 2015 22:29:50 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Joris Van Remoortere.

Bugs: MESOS-3326

Repository: mesos


See MESOS-3326. We adopted std::atomic in most of the code base earlier (commits
87de003c6e8a, 4b938052b6af, and 4a01850c5540), but a few places were omitted;
those locations are fixed by this commit.

There's one remaining place to improve: we use the GCC intrinsic
__sync_synchronize() in 3rdparty/libprocess/include/process/logging.h. Because
that is used to protect modifications to the FLAGS_v variable defined by glog,
we can't easily adapt it to use std::atomic.


  3rdparty/libprocess/include/process/owned.hpp bc5b527152c8864544ad58070c0bfc81639056da 
  3rdparty/libprocess/include/process/shared.hpp 021807b961bb55f11c9e04327135bd83f4d86c21

  3rdparty/libprocess/src/tests/process_tests.cpp e5277de5b5bdea4a44606cda7fbf69a559aeebbe



make check


Neil Conway

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message