mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.
Date Wed, 14 Oct 2015 15:35:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 5:35 p.m.)


Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.


Changes
-------

Updates test.
Fixed some of ben's issues.


Bugs: MESOS-3705
    https://issues.apache.org/jira/browse/MESOS-3705


Repository: mesos


Description
-------

When using the same socket to send multiple HTTP requests to different actors. If the actor
responsible for handling the first request is stuck handling another event while a subsequent
request can reply immediatly, the order of the responses is altered violating HTTP Pipelining.

This patch fixes that problem enforcing that every response is sent in the order the corresponding
request arrived. It also adds a test to reproduce the issue and verify the fix works.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/event.hpp 16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/src/process.cpp 0454554e7b6a39f94cfea02f08ca51ef6b35859a 
  3rdparty/libprocess/src/tests/http_tests.cpp d13d3888abbf3db552df4a9f83e54667e598ded9 

Diff: https://reviews.apache.org/r/39276/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message