mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.
Date Tue, 13 Oct 2015 20:20:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39220/#review102525
-----------------------------------------------------------

Ship it!


Ship It!

- Joseph Wu


On Oct. 13, 2015, 11:36 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39220/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 11:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3615, MESOS-3627, MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, MESOS-3633,
MESOS-3658, MESOS-3659, MESOS-3660, and MESOS-3693
>     https://issues.apache.org/jira/browse/MESOS-3615
>     https://issues.apache.org/jira/browse/MESOS-3627
>     https://issues.apache.org/jira/browse/MESOS-3628
>     https://issues.apache.org/jira/browse/MESOS-3629
>     https://issues.apache.org/jira/browse/MESOS-3630
>     https://issues.apache.org/jira/browse/MESOS-3631
>     https://issues.apache.org/jira/browse/MESOS-3633
>     https://issues.apache.org/jira/browse/MESOS-3658
>     https://issues.apache.org/jira/browse/MESOS-3659
>     https://issues.apache.org/jira/browse/MESOS-3660
>     https://issues.apache.org/jira/browse/MESOS-3693
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Added `slave/state.cpp` to Windows builds.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a5a66c13496a95bb7095504a4645909d887fb49f 
>   src/CMakeLists.txt 536a99f3dc2f48e6002e70b605598f4d218a4324 
> 
> Diff: https://reviews.apache.org/r/39220/diff/
> 
> 
> Testing
> -------
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS
X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message