mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.
Date Tue, 13 Oct 2015 20:16:40 GMT


> On Oct. 13, 2015, 7:38 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chsize.hpp, lines 24-25
> > <https://reviews.apache.org/r/39217/diff/2/?file=1097628#file1097628line24>
> >
> >     This doc says that `ftruncate` needs an open fd too:
> >     http://pubs.opengroup.org/onlinepubs/7908799/xsh/ftruncate.html

Oh. Yes, sorry, I misread the comments of an important OSS codebase that ported `ftruncate`.
Basically, what they said was that there is no equivalent of `truncate`, so you have to open
the file to truncate it. They did not say, as I had thought, that the file descriptor doesn't
need to be open on POSIX. My mistake. Of course in retrospect it has to be an open file descriptor.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39217/#review102343
-----------------------------------------------------------


On Oct. 13, 2015, 6:35 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39217/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 6:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added `stout/os/chsize.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chsize.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chsize.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chsize.hpp PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/39217/diff/
> 
> 
> Testing
> -------
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS
X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message