mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39217: Windows: Added `stout/os/chsize.hpp`.
Date Tue, 13 Oct 2015 19:38:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39217/#review102343
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 67)
<https://reviews.apache.org/r/39217/#comment160189>

    Nit: We want the trailing slashes to line up on RB.



3rdparty/libprocess/3rdparty/stout/include/Makefile.am (line 96)
<https://reviews.apache.org/r/39217/#comment160190>

    Nit: We want the trailing slashes to line up on RB.



3rdparty/libprocess/3rdparty/stout/include/stout/os/chsize.hpp (lines 21 - 23)
<https://reviews.apache.org/r/39217/#comment160194>

    Can you rename the files/methods?
    
    `chsize` seems to be the Windows name.  But `ftruncate` seems to better describe what
the method is doing.



3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chsize.hpp (lines 24 - 25)
<https://reviews.apache.org/r/39217/#comment160193>

    This doc says that `ftruncate` needs an open fd too:
    http://pubs.opengroup.org/onlinepubs/7908799/xsh/ftruncate.html


- Joseph Wu


On Oct. 13, 2015, 11:35 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39217/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 11:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added `stout/os/chsize.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chsize.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/chsize.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/chsize.hpp PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/39217/diff/
> 
> 
> Testing
> -------
> 
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS
X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message