mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic
Date Tue, 13 Oct 2015 03:17:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review102383
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38279, 38517, 38564]

All tests passed.

- Mesos ReviewBot


On Oct. 13, 2015, 1:39 a.m., Felix Abecassis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 1:39 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
>     https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp 0c1042a 
>   src/examples/test_hook_module.cpp cd7c184 
>   src/hook/manager.hpp 3af1ff8 
>   src/hook/manager.cpp 108bd46 
>   src/slave/slave.cpp 01c5e42 
>   src/tests/hook_tests.cpp b35ce72 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message