mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.
Date Mon, 12 Oct 2015 19:26:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39202/#review102300
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/CMakeLists.txt (line 124)
<https://reviews.apache.org/r/39202/#comment159904>

    Templatize and rename upon copy.  (See comment below).



3rdparty/libprocess/3rdparty/CMakeLists.txt 
<https://reviews.apache.org/r/39202/#comment159901>

    Where are you moving this to?
    (Or why do we *not* need to build Gmock now?)



3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt (line 17)
<https://reviews.apache.org/r/39202/#comment159903>

    Since you copy this file into its final destination, could you make this a template?
    
    i.e. Rename to `CMakeLists.txt.template`.


- Joseph Wu


On Oct. 9, 2015, 9:36 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39202/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 9:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Moved libevent, gmock, http-parser to CMake on Windows.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt f0de224b0d7924344fb1945b387b728a7241df87

>   3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt PRE-CREATION 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 60108ff598fb075584196aa3d8e8e66e726c9f2a

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake ea6db09e1a1aa01450aee93814e07f09feae7ac9

> 
> Diff: https://reviews.apache.org/r/39202/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message