mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.
Date Mon, 12 Oct 2015 19:11:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39201/#review102297
-----------------------------------------------------------

Ship it!


Ship It!

- Joseph Wu


On Oct. 9, 2015, 9:31 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39201/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Windows integration work will require us to support `stout/net.hpp`,
> but this file includes `stout/os.hpp`, which would be onerous to port.
> 
> To avoid having to port that entire file, we simply roped in what we
> needed from `stout/net.hpp`. A consequence of unincluding os.hpp is that
> `process/future.hpp` now requires a direct inclusion of
> `stout/check.hpp`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 9006b8a83d03eab6e67de12a954110029b7d150e

> 
> Diff: https://reviews.apache.org/r/39201/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message