mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 37993: Add explanatory comments for Allocator interface
Date Mon, 12 Oct 2015 18:15:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review102266
-----------------------------------------------------------

Ship it!


I've shipped this patch with the minor typos and style fixes outlined below.


include/mesos/master/allocator.hpp (lines 111 - 112)
<https://reviews.apache.org/r/37993/#comment159849>

    Indent 4 spaces.



include/mesos/master/allocator.hpp (line 153)
<https://reviews.apache.org/r/37993/#comment159850>

    `s/new/newly/`



include/mesos/master/allocator.hpp (line 229)
<https://reviews.apache.org/r/37993/#comment159858>

    `s/a/the/`



include/mesos/master/allocator.hpp (line 231)
<https://reviews.apache.org/r/37993/#comment159859>

    `s/invokved/invoked/`
    `s/a whitelist flag/the --whitelist flag`



include/mesos/master/allocator.hpp (line 254)
<https://reviews.apache.org/r/37993/#comment159861>

    `s/reservationa/reservation/`



include/mesos/master/allocator.hpp (line 333)
<https://reviews.apache.org/r/37993/#comment159874>

    `s/when//`



include/mesos/master/allocator.hpp (line 342)
<https://reviews.apache.org/r/37993/#comment159877>

    `s/for/to/`


- Michael Park


On Oct. 6, 2015, 12:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 12:26 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
>     https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 8100f14220599247a340c919a03f29755b5349d8 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message