mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.
Date Mon, 12 Oct 2015 11:59:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38950/#review102238
-----------------------------------------------------------



include/mesos/authentication/http/basic_authenticator_factory.hpp (line 33)
<https://reviews.apache.org/r/38950/#comment159806>

    virtual



src/examples/test_http_authenticator_module.cpp (line 21)
<https://reviews.apache.org/r/38950/#comment159808>

    put this under #include <mesos/module.hpp>



src/tests/http_authentication_tests.cpp (lines 19 - 34)
<https://reviews.apache.org/r/38950/#comment159810>

    #include <string>
    
    #include <gtest/gtest.h>
    
    #include <process/authenticator.hpp>
    #include <process/gtest.hpp>
    
    #include <stout/hashmap.hpp>
    #include <stout/hashset.hpp>
    
    #include "tests/mesos.hpp"
    #include "tests/module.hpp"
    
    #include <mesos/authentication/http/basic_authenticator_factory.hpp>
    
    #include <mesos/module/http_authenticator.hpp>



src/tests/http_authentication_tests.cpp (lines 42 - 46)
<https://reviews.apache.org/r/38950/#comment159811>

    using std::string;
    
    using mesos::http::BasicAuthenticatorFactory;
    
    using process::http::Authenticator;


- Guangya Liu


On 十月 12, 2015, 9:30 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38950/
> -----------------------------------------------------------
> 
> (Updated 十月 12, 2015, 9:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3232
>     https://issues.apache.org/jira/browse/MESOS-3232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds support for modularization of HTTP Authenticators. 
> 
> It includes an example of how to do it with the Basic HTTP Authenticator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION 
>   include/mesos/module/http_authenticator.hpp PRE-CREATION 
>   src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d 
>   src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e 
>   src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
>   src/examples/test_http_authenticator_module.cpp PRE-CREATION 
>   src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
>   src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
>   src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
>   src/tests/http_authentication_tests.cpp PRE-CREATION 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 
> 
> Diff: https://reviews.apache.org/r/38950/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message