mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Review Request 39207: Windows: Move `write` to its own file, `stout/os/write.hpp`.
Date Sat, 10 Oct 2015 19:46:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39207/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3632
    https://issues.apache.org/jira/browse/MESOS-3632


Repository: mesos


Description
-------

Windows: Move `write` to its own file, `stout/os/write.hpp`.

(This part isn't going in the commit message, but just FYI, we're doing this (1) because we
need it to support `slave/state.hpp`, (2) because we don't want to port all of `os.hpp` to
get this one function, and (3) because `stout/os/read.hpp` already exists, so it makes sense
to have one for `write` as well.)

(Also, please do not close MESOS-3632, this is just a partial solution.)


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5141c1369af60afd6cd5c70c6295d575ea960a83

  3rdparty/libprocess/3rdparty/stout/include/stout/os/write.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5

  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 2b0966889af73238a08e29f1136d0ce286a0ffda


Diff: https://reviews.apache.org/r/39207/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message