mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 38943: Fixed misleading information in the Mesos framework writing guide.
Date Fri, 09 Oct 2015 08:50:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38943/#review102031
-----------------------------------------------------------

Ship it!


Minor nits/tweaks, but I'll fix those myself before I commit this.
Thanks for updating our docs!


docs/app-framework-development-guide.md (line 135)
<https://reviews.apache.org/r/38943/#comment159563>

    s/shell commands/shell commands and Docker containers/



docs/app-framework-development-guide.md (line 137)
<https://reviews.apache.org/r/38943/#comment159565>

    Unnecessary space (' ') before period.



docs/app-framework-development-guide.md (line 231)
<https://reviews.apache.org/r/38943/#comment159568>

    or FTP!


- Adam B


On Oct. 1, 2015, 5:16 p.m., Connor Doyle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38943/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 5:16 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The framework author's guide contained some misleading and incomplete information.
> 
> Added description of the Mesos command executor.
> Fixed outdated information about how to use ExecutorInfo.
> Added a link to the Mesos fetcher user documentation.
> 
> 
> Diffs
> -----
> 
>   docs/app-framework-development-guide.md c7aa08d 
> 
> Diff: https://reviews.apache.org/r/38943/diff/
> 
> 
> Testing
> -------
> 
> Visually verified the generated output in Chrome, using http://github.com/mesosphere/mesos-website-container.
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message