> On Oct. 7, 2015, 2:18 p.m., Ben Mahler wrote:
> > src/tests/script.cpp, line 101
> > <https://reviews.apache.org/r/39008/diff/1/?file=1091884#file1091884line101>
> >
> > malloc is not async-signal-safe, and may be used by the string implementation,
and so we must not use os::strerror (assuming we rename it) after a fork! Please do an audit
of this diff.
Yikes. Good catch. I glossed over the fork. My bad.
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/#review101811
-----------------------------------------------------------
On Oct. 6, 2015, 8:08 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39008/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 8:08 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
>
>
> Bugs: MESOS-3551
> https://issues.apache.org/jira/browse/MESOS-3551
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Switch call sites to using safe strerror_r wrapper.
>
>
> Diffs
> -----
>
> src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12
> src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89
> src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390
> src/linux/routing/link/internal.hpp 015c0ef5be516d7786c96a96437cced1ae8487fa
> src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a
> src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf
> src/slave/containerizer/isolators/filesystem/linux.cpp 8823b7850a1ac17fc4f4868aadf1b04428d2381b
> src/slave/containerizer/isolators/filesystem/posix.cpp eec510c4f7655d67b33ad90210eeb57fcc910684
> src/slave/containerizer/isolators/filesystem/shared.cpp 73804ca5a8a3bf03e13c74a247b5c21e9af5f040
> src/slave/containerizer/mesos/containerizer.cpp b904b2d88e9b62fa4ba312c4569a4d89b0dc6052
> src/slave/containerizer/mesos/launch.cpp 09d4d8f4d6837e93a82deef76ca07e2167d6a405
> src/slave/containerizer/provisioner/backends/bind.cpp 1fe1746c0bc1c9c12e1378e6438122a91b58316b
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
> src/tests/containerizer/memory_test_helper.cpp 8109a4314c0dcf17c5fe124d9b87ac856b3a922a
> src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0
>
> Diff: https://reviews.apache.org/r/39008/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|