mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <>
Subject Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'
Date Thu, 08 Oct 2015 01:00:35 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 8, 2015, 1 a.m.)

Review request for mesos and Michael Park.


Added java framework example changes

Bugs: MESOS-3560

Repository: mesos


When decoding the JSON credential file into the Credential protobuf object, the 'secret' which
is in 'bytes' is mapped into base64 string automatically by protobuf from JSON. This creates
an unintended behavior, forcing users to encode in base64 their secret when wanting to pass
a JSON file to the --credentials flag.

Diffs (updated)

  include/mesos/mesos.proto 4a16be1 
  src/examples/java/ 78720b0 
  src/examples/java/ aad94c0 



make check


Isabel Jimenez

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message