mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API
Date Wed, 07 Oct 2015 19:39:30 GMT


> On Oct. 7, 2015, 6:40 p.m., Isabel Jimenez wrote:
> > Ship It!

LGTM, just might need to get rebase on changes for switch syntax in other patches.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101805
-----------------------------------------------------------


On Oct. 7, 2015, 6:39 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 6:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-2295
>     https://issues.apache.org/jira/browse/MESOS-2295
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp`
to handle ExecutorToFrameworkMessage.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b 
> 
> Diff: https://reviews.apache.org/r/38899/diff/
> 
> 
> Testing
> -------
> 
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message