mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <>
Subject Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'
Date Wed, 07 Oct 2015 19:06:01 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Michael Park.

Bugs: MESOS-3560

Repository: mesos


When decoding the JSON credential file into the Credential protobuf object, the 'secret' which
is in 'bytes' is mapped into base64 string automatically by protobuf from JSON. This creates
an unintended behavior, forcing users to encode in base64 their secret when wanting to pass
a JSON file to the --credentials flag.


  include/mesos/mesos.proto 4a16be1 



make check


Isabel Jimenez

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message