-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/#review101785
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines 105 - 109)
<https://reviews.apache.org/r/39076/#comment159275>
Nit: Can you change this to a if-else (minus the elseif)?
- Joseph Wu
On Oct. 7, 2015, 1:31 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39076/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 1:31 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added ability of Windows builds to include protobuf headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
>
> Diff: https://reviews.apache.org/r/39076/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
|