mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 39013: RegistryClient refactor: Fixed comments style.
Date Tue, 06 Oct 2015 19:42:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39013/#review101680
-----------------------------------------------------------

Ship it!


Thanks for pulling away the dependencies, I'll commit this shortly without the const change.


src/slave/containerizer/provisioner/docker/registry_client.hpp (line 53)
<https://reviews.apache.org/r/39013/#comment159136>

    Ah, please avoid slipping in other changes like this, looks like this belongs in your
layer id patch.


- Ben Mahler


On Oct. 6, 2015, 2:30 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39013/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2015, 2:30 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> RegistryClient refactor: Fixed comments style.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 9d5d15455192e2d75fe5cd7fa8755fb8cc67e185

>   src/slave/containerizer/provisioner/docker/registry_client.cpp c2040b48ea43fdb29766994c244273d3fa9ee3cd

> 
> Diff: https://reviews.apache.org/r/39013/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message