mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Review Request 39043: Added support for HTTP Authentication in Mesos.
Date Tue, 06 Oct 2015 14:56:53 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39043/
-----------------------------------------------------------

Review request for mesos, Adam B, Bernd Mathiske, Isabel Jimenez, and Till Toenshoff.


Bugs: MESOS-3232
    https://issues.apache.org/jira/browse/MESOS-3232


Repository: mesos


Description
-------

1. Adds a flag to load an HTTP Authenticator module from the flags.
2. If provided, uses the credentials file to initialize the default HTTP Authenticator.
3. Updates the existing endpoints which implement their own basic HTTP authenticator with
the libprocess one.
4. Updates one test which expected the wrong results since now credentials are checked before
the body of the request.


Diffs
-----

  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6 
  src/master/flags.cpp 0285ce70cefca09e81ef7137968d024e297fec87 
  src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660 
  src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f 
  src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b 
  src/tests/teardown_tests.cpp 2eeead74b877e282660c4009910c42d93ef3ff46 

Diff: https://reviews.apache.org/r/39043/diff/


Testing
-------

make check


Thanks,

Alexander Rojas
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message