mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events
Date Mon, 05 Oct 2015 23:04:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38873/#review101550
-----------------------------------------------------------


LGTM just small nit from standing review issue

- Isabel Jimenez


On Sept. 30, 2015, 3:38 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38873/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2015, 3:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
>     https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change implements helper functions for evolving old style Executor messages in `src/messages/messages.proto`
to V1 Executor Events defined in `include/mesos/v1/executor/executor.proto`. This is needed
for MESOS-3480
> 
> 
> Diffs
> -----
> 
>   src/internal/evolve.hpp 9babac3ccbfb2bf9a3989a3ae20cf96e5f3a2903 
>   src/internal/evolve.cpp 625706e089984b32d8298a2eacf2f8af2bca931e 
> 
> Diff: https://reviews.apache.org/r/38873/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message