mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38608: Added an http::Connection for connection re-use and pipelining.
Date Mon, 05 Oct 2015 23:00:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38608/#review101540
-----------------------------------------------------------


LGTM! Nice tests!


3rdparty/libprocess/src/http.cpp (line 783)
<https://reviews.apache.org/r/38608/#comment158961>

    s/`socket_`/`_socket`/?
    
    underscore suffix makes it more look like a member (Google style).



3rdparty/libprocess/src/http.cpp (line 979)
<https://reviews.apache.org/r/38608/#comment158963>

    Owned, instead of a raw pointer? Save a 'delete' in `~Data()`.



3rdparty/libprocess/src/tests/http_tests.cpp (line 721)
<https://reviews.apache.org/r/38608/#comment158972>

    Remove one extra blank line here.


- Jie Yu


On Oct. 3, 2015, 12:04 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38608/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3332
>     https://issues.apache.org/jira/browse/MESOS-3332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In order to support connection re-use and pipelining of requests on a shared connection,
this introduces the notion of an http::Connection.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416

>   3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015 
>   3rdparty/libprocess/src/tests/http_tests.cpp c380f356548cf9f5491044bccabcd9c66ad5f55a

> 
> Diff: https://reviews.apache.org/r/38608/diff/
> 
> 
> Testing
> -------
> 
> Added tests.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message