mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38609: Refactored http::internal::request to use http::connect.
Date Thu, 01 Oct 2015 01:45:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38609/#review101185
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38595, 38596, 38597, 38598, 38600, 38599, 38601, 38603, 38604, 38605, 38606,
38607, 38608, 38609]

All tests passed.

- Mesos ReviewBot


On Oct. 1, 2015, 12:19 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38609/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2015, 12:19 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gets rid of the duplicated code, in favor of leveraging http::Connection.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416

>   3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015 
> 
> Diff: https://reviews.apache.org/r/38609/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message