From reviews-return-10813-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Sep 25 20:29:03 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B78CE1820C for ; Fri, 25 Sep 2015 20:29:03 +0000 (UTC) Received: (qmail 52273 invoked by uid 500); 25 Sep 2015 20:29:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 52251 invoked by uid 500); 25 Sep 2015 20:29:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 52233 invoked by uid 99); 25 Sep 2015 20:29:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Sep 2015 20:29:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B41CA2870CB; Fri, 25 Sep 2015 20:29:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3949118591849994658==" MIME-Version: 1.0 Subject: Re: Review Request 38752: CMake: Transition Mesos to use new third-party build scripts. From: "Joris Van Remoortere" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Joseph Wu" Cc: "Alex Clemmer" , "mesos" Date: Fri, 25 Sep 2015 20:29:00 -0000 Message-ID: <20150925202900.24659.61616@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38752/ X-Sender: "Joris Van Remoortere" References: <20150925061853.24658.71117@reviews.apache.org> In-Reply-To: <20150925061853.24658.71117@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos --===============3949118591849994658== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38752/#review100676 ----------------------------------------------------------- You'll need to split this up as it's touching 2 different projects: ``` ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: mesos: cmake/MesosConfigure.cmake libprocess: 3rdparty/libprocess/3rdparty/CMakeLists.txt Failed to commit patch ``` - Joris Van Remoortere On Sept. 25, 2015, 6:18 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38752/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 6:18 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > CMake: Transition Mesos to use new third-party build scripts. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d > cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 > > Diff: https://reviews.apache.org/r/38752/diff/ > > > Testing > ------- > > Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms: > > * OS X 10.10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > > --===============3949118591849994658==--