> On Sept. 15, 2015, 11:12 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 223-225
> > <https://reviews.apache.org/r/37273/diff/10/?file=1074337#file1074337line223>
> >
> >     Just curious, why aren't you using the protobuf-2.5.0 tarball that's included in the mesos source?
> >     
> >     I can imagine that you could use the included tarball for everything other than glog (which requires 0.3.4+).
> >     
> >     See:
> >     https://github.com/apache/mesos/tree/master/3rdparty/libprocess/3rdparty

Oh, this one contains the patch that could compiled upder vs 2015.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review99115
-----------------------------------------------------------


On Sept. 15, 2015, 6:42 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64 
>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>