From reviews-return-9763-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 16 02:12:00 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8EE7818B36 for ; Wed, 16 Sep 2015 02:12:00 +0000 (UTC) Received: (qmail 75132 invoked by uid 500); 16 Sep 2015 02:12:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 75107 invoked by uid 500); 16 Sep 2015 02:12:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 75087 invoked by uid 99); 16 Sep 2015 02:12:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Sep 2015 02:12:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C4ED3283B26; Wed, 16 Sep 2015 02:11:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2749736596931235450==" MIME-Version: 1.0 Subject: Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess. From: "haosdent huang" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Alex Clemmer" , "Joseph Wu" Cc: "haosdent huang" , "mesos" Date: Wed, 16 Sep 2015 02:11:58 -0000 Message-ID: <20150916021158.3774.24185@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "haosdent huang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/37273/ X-Sender: "haosdent huang" References: <20150915231232.3774.1074@reviews.apache.org> In-Reply-To: <20150915231232.3774.1074@reviews.apache.org> Reply-To: "haosdent huang" X-ReviewRequest-Repository: mesos --===============2749736596931235450== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 15, 2015, 11:12 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 223-225 > > > > > > Just curious, why aren't you using the protobuf-2.5.0 tarball that's included in the mesos source? > > > > I can imagine that you could use the included tarball for everything other than glog (which requires 0.3.4+). > > > > See: > > https://github.com/apache/mesos/tree/master/3rdparty/libprocess/3rdparty Oh, this one contains the patch that could compiled upder vs 2015. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review99115 ----------------------------------------------------------- On Sept. 15, 2015, 6:42 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37273/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 6:42 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Add CMake macro VsBuildCommand in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64 > 3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION > 3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/37273/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > > --===============2749736596931235450==--