From reviews-return-9161-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Sep 9 22:20:51 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53A3117307 for ; Wed, 9 Sep 2015 22:20:51 +0000 (UTC) Received: (qmail 52470 invoked by uid 500); 9 Sep 2015 22:20:51 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 52448 invoked by uid 500); 9 Sep 2015 22:20:51 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 52432 invoked by uid 99); 9 Sep 2015 22:20:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Sep 2015 22:20:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1B5EB271A5E; Wed, 9 Sep 2015 22:20:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6773931536407668808==" MIME-Version: 1.0 Subject: Re: Review Request 38076: [4/5] Integer Precision for JSON <-> Protobuf conversions. From: "Joseph Wu" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Ben Mahler" , "Vinod Kone" Cc: "Joseph Wu" , "mesos" Date: Wed, 09 Sep 2015 22:20:50 -0000 Message-ID: <20150909222050.12751.59102@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joseph Wu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38076/ X-Sender: "Joseph Wu" References: <20150909185855.12751.94440@reviews.apache.org> In-Reply-To: <20150909185855.12751.94440@reviews.apache.org> Reply-To: "Joseph Wu" X-ReviewRequest-Repository: mesos --===============6773931536407668808== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38076/ ----------------------------------------------------------- (Updated Sept. 9, 2015, 3:20 p.m.) Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone. Changes ------- Ready for wider review. Summary (updated) ----------------- [4/5] Integer Precision for JSON <-> Protobuf conversions. Repository: mesos Description ------- Modify one libprocess test which originally fetched an integer as a double. Diffs (updated) ----- 3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a Diff: https://reviews.apache.org/r/38076/diff/ Testing ------- Testing is done in the next review. Thanks, Joseph Wu --===============6773931536407668808==--